Skip to content

ci(release): verify client artifacts instead of silent || true#70

Closed
yaroslavmokflmg wants to merge 4 commits into
mainfrom
hotfix/release-verify-client-artifacts
Closed

ci(release): verify client artifacts instead of silent || true#70
yaroslavmokflmg wants to merge 4 commits into
mainfrom
hotfix/release-verify-client-artifacts

Conversation

@yaroslavmokflmg

@yaroslavmokflmg yaroslavmokflmg commented Jul 8, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

release.yml relied on 'gh release download latest ... || true' — any download failure was swallowed. Combined with a conditionally-skipped build_client, a release could ship missing/stale client binaries while the run stayed green. Now: carry-forward runs only when a latest release exists (first-release case still works), download failures are no longer silenced, and both client platforms are verified present before publishing (fail otherwise).

Summary by CodeRabbit

  • Bug Fixes
    • Improved release packaging checks to prevent publishing incomplete client builds.
    • Added safer handling when no previous “latest” release is available, avoiding failed artifact carry-forward steps.
    • Strengthened release automation so failures are detected earlier and surfaced clearly.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@yaroslavmokflmg, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 702f438c-9d48-4f9a-a21a-99297108edeb

📥 Commits

Reviewing files that changed from the base of the PR and between 33503cb and 9dd6310.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Walkthrough

The release workflow's artifact preparation step was updated to authenticate the GitHub CLI using GH_TOKEN and enforce stricter shell error handling. Carry-forward of previous "latest" release artifacts is now conditional on that release existing, with a log message and skip when it does not. A new validation step checks for the presence of expected macOS and Windows client archives, emitting error annotations and failing the job if either is missing.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change but omits the required Description, Improvements, and Task sections. Add the template sections with a brief description, step-by-step improvements, and a task or issue link.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main release workflow change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/release-verify-client-artifacts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yaroslavmokflmg